Commit 808a9dc5 authored by Martin Jeřábek's avatar Martin Jeřábek
Browse files

driver: add notes and TODOs

parent af2b9742
...@@ -119,6 +119,7 @@ static int ctucan_set_bittiming(struct net_device *ndev) ...@@ -119,6 +119,7 @@ static int ctucan_set_bittiming(struct net_device *ndev)
return -EPERM; return -EPERM;
} }
/* Note that bt may be modified here */
ctu_can_fd_set_nom_bittiming(&priv->p, bt); ctu_can_fd_set_nom_bittiming(&priv->p, bt);
return 0; return 0;
...@@ -147,6 +148,7 @@ static int ctucan_set_data_bittiming(struct net_device *ndev) ...@@ -147,6 +148,7 @@ static int ctucan_set_data_bittiming(struct net_device *ndev)
return -EPERM; return -EPERM;
} }
/* Note that dbt may be modified here */
ctu_can_fd_set_data_bittiming(&priv->p, dbt); ctu_can_fd_set_data_bittiming(&priv->p, dbt);
return 0; return 0;
......
...@@ -260,6 +260,8 @@ void ctu_can_fd_set_mode_reg(struct ctucanfd_priv *priv, const struct can_ctrlmo ...@@ -260,6 +260,8 @@ void ctu_can_fd_set_mode_reg(struct ctucanfd_priv *priv, const struct can_ctrlmo
priv->write_reg(priv, CTU_CAN_FD_MODE, reg.u32); priv->write_reg(priv, CTU_CAN_FD_MODE, reg.u32);
} }
/* TODO: use atomic 16bit accesses instead of read-modify-write */
void ctu_can_fd_rel_rx_buf(struct ctucanfd_priv *priv) void ctu_can_fd_rel_rx_buf(struct ctucanfd_priv *priv)
{ {
union ctu_can_fd_mode_command_status_settings reg; union ctu_can_fd_mode_command_status_settings reg;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment